Introduce request infrastructure for storage access#214
Merged
johannhof merged 2 commits intoprivacycg:mainfrom Mar 26, 2025
Merged
Introduce request infrastructure for storage access#214johannhof merged 2 commits intoprivacycg:mainfrom
request infrastructure for storage access#214johannhof merged 2 commits intoprivacycg:mainfrom
Conversation
3 tasks
johannhof
reviewed
Mar 21, 2025
johannhof
approved these changes
Mar 22, 2025
Member
johannhof
left a comment
There was a problem hiding this comment.
Will wait a few days to see if @bvandersloot-mozilla or @annevk have any concerns and merge otherwise. Thanks Chris!
Member
|
Merging! |
This was referenced Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits out the underlying infrastructure changes introduced in #213 so that #213 can just introduce the behavior change, and this PR can add the infrastructure needed to formally define the current behavior (in Chrome and Firefox; Safari TBD).
I also incorporated @annevk's request that
request/eligible for storage-accessbe a tri-state enum, rather than a boolean.This PR relies on the
environment/ancestryenum, similar to other cookie layering work (e.g.).Preview | Diff